mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 67681: Fixed flaky test `MasterAPITest.SubscribersReceiveHealthUpdates`.
Date Thu, 21 Jun 2018 18:33:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67681/
-----------------------------------------------------------

(Updated June 21, 2018, 11:33 a.m.)


Review request for mesos and Greg Mann.


Changes
-------

Addressed Greg's comment. Removed the last scheduler ack to avoid racing.


Bugs: MESOS-9014
    https://issues.apache.org/jira/browse/MESOS-9014


Repository: mesos


Description
-------

This patch fixes the flaky test by explicitly killing the
task before test tear-down, avoiding the race condition
between scheduler tear-down and scheduler getting/acknowledging
status update.


Diffs (updated)
-----

  src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f 


Diff: https://reviews.apache.org/r/67681/diff/2/

Changes: https://reviews.apache.org/r/67681/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message