mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67670: Added a unit test for disappeared profiles.
Date Thu, 21 Jun 2018 10:24:31 GMT


> On June 20, 2018, 3:14 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1165-1168 (patched)
> > <https://reviews.apache.org/r/67670/diff/1/?file=2042689#file2042689line1165>
> >
> >     This relies strongly on the way the master interprets a zero time, and  how
the allocation interval is related to the default value the master would currently use. Can
we set a value calculated from `masterFlags.allocation_interval` instead to decouple this?
> 
> Chun-Hung Hsiao wrote:
>     I prefer leaving this as is for consistency since we set 0 refuse seconds in other
tests as well. What is the value in your mind? Like just setting it to `masterFlags.allocation_interval`?
But then for event-based allocations the resources might still be refused?

I misread the comment, we here of course explicitly disable the default decline filter. Dropping.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67670/#review205061
-----------------------------------------------------------


On June 21, 2018, 7:02 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67670/
> -----------------------------------------------------------
> 
> (Updated June 21, 2018, 7:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8995
>     https://issues.apache.org/jira/browse/MESOS-8995
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `ROOT_ProfileDisappeared` tests if a `CREATE_VOLUME` consuming a RAW
> disk with a disappeared profile will be dropped, and if the disk space
> freed by a `DESTROY_VOLUME` destroying a volume with a disappeared
> profile will be recovered with a newly appeared profile.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5

> 
> 
> Diff: https://reviews.apache.org/r/67670/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message