mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67669: Allowed allocation quantities to be changed when updating the sorter.
Date Thu, 21 Jun 2018 04:52:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67669/
-----------------------------------------------------------

(Updated June 21, 2018, 4:52 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng Zhu.


Changes
-------

Partially addressed Benjamin's comment.


Summary (updated)
-----------------

Allowed allocation quantities to be changed when updating the sorter.


Bugs: MESOS-8995
    https://issues.apache.org/jira/browse/MESOS-8995


Repository: mesos


Description (updated)
-------

This patch allows the allocator to change allocation quantities when
calling `Sorter::update`, so Mesos can support arbitrary resource
conversions.

An example usage is that we can make `DESTROY_VOLUME` to convert a
volume with a stale profile to an empty resource, so the disk space
will disappear instead of being offered out to other frameworks.


Diffs (updated)
-----

  CHANGELOG 0e44277389e5a96c221d6c3d501da2bb93d27faa 
  docs/upgrades.md cc8a251945af27a432dbeb5585b998cd84e35b22 
  src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 
  src/master/allocator/sorter/drf/sorter.cpp 755a36ead42a91053c881fc46dc6acb39c819cac 
  src/master/allocator/sorter/sorter.hpp e5e86513dc4023d9c471753897635923c6c9203f 
  src/tests/sorter_tests.cpp 9cdffd778967bca3d0055be8a04fbb702432e59d 


Diff: https://reviews.apache.org/r/67669/diff/2/

Changes: https://reviews.apache.org/r/67669/diff/1-2/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message