mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 67669: Removed an invariant check when updating the hierarchical allocator.
Date Wed, 20 Jun 2018 05:34:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67669/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng Zhu.


Bugs: MESOS-8995
    https://issues.apache.org/jira/browse/MESOS-8995


Repository: mesos


Description
-------

`HierarchicalAllocatorProcess::updateAllocation` checks that the given
resource conversions should not change the allocation quantities of the
specified framework. Although this is true for speculative operations,
this might not hold for arbitrary resource conversions in general.

Since the allocator does not rely on this invariant, this patch relaxes
the invariant to make resource conversions more future-proof.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c 


Diff: https://reviews.apache.org/r/67669/diff/1/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message