mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 67597: Fixed an issue where agent may fail to recover.
Date Thu, 14 Jun 2018 23:22:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67597/#review204806
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp
Lines 269-273 (patched)
<https://reviews.apache.org/r/67597/#comment287537>

    I don't think we need to remove this file since it will be overwritten once there is next
successful container launch.
    
    Let's return a `WARNING` and unblock the agent from recovery.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp
Lines 274 (patched)
<https://reviews.apache.org/r/67597/#comment287538>

    newline above.


- Gilbert Song


On June 14, 2018, 12:48 a.m., bin zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67597/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 12:48 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8871
>     https://issues.apache.org/jira/browse/MESOS-8871
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed an issue where agent may fail to recover if the agent dies before image store cache
to the checkpoint. when images file is empty, remove it and continue.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 98c8fc769f2525c66539f08e2aa82506912e8a59

>   src/tests/containerizer/provisioner_docker_tests.cpp 71247c308b205de3d20a41ceb06eed6aa70fb25d

> 
> 
> Diff: https://reviews.apache.org/r/67597/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> bin zheng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message