mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67551: Fixed `push-commits.py` for Windows.
Date Wed, 13 Jun 2018 07:38:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67551/#review204666
-----------------------------------------------------------


Ship it!




Ship It!

- Armand Grillet


On June 12, 2018, 5:41 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67551/
> -----------------------------------------------------------
> 
> (Updated June 12, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This script didn't work even before the port to Python 3, as
> `os.path.join` cannot be used for joining URL components, as the
> filesystem path separator on Windows is a backslash.
> 
> 
> Diffs
> -----
> 
>   support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 
> 
> 
> Diff: https://reviews.apache.org/r/67551/diff/1/
> 
> 
> Testing
> -------
> 
> > python .\support\python3\push-commits.py --dry-run
> Pushing commits to apache
> To https://git-wip-us.apache.org/repos/asf/mesos.git
>    f1c0377a9..8ffe29363  master -> master
> Closing review 67551
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message