mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67223: Used move constructors for making CSI gRPC calls.
Date Fri, 08 Jun 2018 01:23:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/
-----------------------------------------------------------

(Updated June 8, 2018, 1:23 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.


Changes
-------

Rebased.


Bugs: MESOS-8924
    https://issues.apache.org/jira/browse/MESOS-8924


Repository: mesos


Description
-------

This patch takes the advantages of the moving constructors of the CSI
request protobuf messages to avoid copying the messages.


Diffs (updated)
-----

  src/csi/client.hpp 1c57ac52ade6295d5c45ac8a439ea572d16d7ae3 
  src/csi/client.cpp 923ee6f85dc8070d60bee9834846f859883c73df 
  src/resource_provider/storage/provider.cpp 333336e9109d8cdc7fc1fa29582e2717b84e3e60 


Diff: https://reviews.apache.org/r/67223/diff/2/

Changes: https://reviews.apache.org/r/67223/diff/1-2/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message