mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Review Request 67476: Added guideline for contributions modifying Makefile.am.
Date Wed, 06 Jun 2018 13:56:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67476/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Repository: mesos


Description
-------

While rare, contributions which modify any `Makefile.am` (usually
because they add or remove files) tend to break the `distcheck` target
as well as the cmake build system.

This patch adds a section so contributors are aware that they need to
check that all build system and all make targets work when modifying
`Makefile.am` files.


Diffs
-----

  docs/advanced-contribution.md f95149120d39b9517ace3ec0ac37d82d3d3a77c4 


Diff: https://reviews.apache.org/r/67476/diff/1/


Testing
-------

Not a code related change.


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message