mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)
Date Wed, 16 May 2018 17:38:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67075/#review203255
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/tests/subprocess_tests.cpp
Lines 807 (patched)
<https://reviews.apache.org/r/67075/#comment285357>

    `path::join` joins with `os::PATH_SEPARATOR` aka `\`. You can remove the `\` from the
second argument :)


- Andrew Schwartzmeyer


On May 16, 2018, 10:07 a.m., Radhika Jandhyala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67075/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 10:07 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-8857
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/67152
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 1b2d75d2b576e528db49635fce54174d56a29c59

>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 269918e7f795bb62f8acd84cfc4233ff8682f90d

>   3rdparty/libprocess/src/tests/test_echo.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67075/diff/3/
> 
> 
> Testing
> -------
> 
> [----------] 18 tests from SubprocessTest
> [ RUN      ] SubprocessTest.PipeOutputToFileDescriptor
> [       OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms)
> [ RUN      ] SubprocessTest.PipeOutputToPath
> [       OK ] SubprocessTest.PipeOutputToPath (33 ms)
> [ RUN      ] SubprocessTest.EnvironmentEcho
> [       OK ] SubprocessTest.EnvironmentEcho (22 ms)
> [ RUN      ] SubprocessTest.Status
> [       OK ] SubprocessTest.Status (29 ms)
> [ RUN      ] SubprocessTest.PipeOutput
> [       OK ] SubprocessTest.PipeOutput (25 ms)
> [ RUN      ] SubprocessTest.PipeLargeOutput
> [       OK ] SubprocessTest.PipeLargeOutput (18 ms)
> [ RUN      ] SubprocessTest.PipeInput
> [       OK ] SubprocessTest.PipeInput (248 ms)
> [ RUN      ] SubprocessTest.PipeRedirect
> [       OK ] SubprocessTest.PipeRedirect (31 ms)
> [ RUN      ] SubprocessTest.PathOutput
> [       OK ] SubprocessTest.PathOutput (54 ms)
> [ RUN      ] SubprocessTest.PathInput
> [       OK ] SubprocessTest.PathInput (232 ms)
> [ RUN      ] SubprocessTest.FdOutput
> [       OK ] SubprocessTest.FdOutput (45 ms)
> [ RUN      ] SubprocessTest.FdInput
> [       OK ] SubprocessTest.FdInput (237 ms)
> [ RUN      ] SubprocessTest.Default
> hello world
> [       OK ] SubprocessTest.Default (21 ms)
> [ RUN      ] SubprocessTest.Flags
> [       OK ] SubprocessTest.Flags (34 ms)
> [ RUN      ] SubprocessTest.Environment
> [       OK ] SubprocessTest.Environment (32 ms)
> [ RUN      ] SubprocessTest.EnvironmentWithSpaces
> [       OK ] SubprocessTest.EnvironmentWithSpaces (19 ms)
> [ RUN      ] SubprocessTest.EnvironmentWithSpacesAndQuotes
> [       OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms)
> [ RUN      ] SubprocessTest.EnvironmentOverride
> [       OK ] SubprocessTest.EnvironmentOverride (17 ms)
> [----------] 18 tests from SubprocessTest (1201 ms total)
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message