mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James DeFelice <james.defel...@gmail.com>
Subject Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.
Date Fri, 11 May 2018 12:05:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67078/#review202928
-----------------------------------------------------------




src/resource_provider/storage/uri_disk_profile_adaptor.cpp
Line 281 (original)
<https://reviews.apache.org/r/67078/#comment284986>

    this seems like a pretty aggressive change. instead of removing the attempted optimization
completely, why not fix it instead?
    
    IMO it seems like it would be cheaper to do an equivalence check here and skip the subsequent
notifications if nothing has changed. we don't expect profiles to change very frequently.


- James DeFelice


On May 11, 2018, 3:32 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67078/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 3:32 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8906
>     https://issues.apache.org/jira/browse/MESOS-8906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `UriDiskProfileAdaptor` be able to update profile selectors.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp 300ea12687de487737ce91066ab4e74d9b3430e6

> 
> 
> Diff: https://reviews.apache.org/r/67078/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message