mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67025: Fixed the link order for gRPC in CMake.
Date Wed, 09 May 2018 18:53:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67025/#review202784
-----------------------------------------------------------


Ship it!




Examined this with Chun over DM. Brad King (of CMake) has stated at least in mailing list
threads that the order of the libraries specified here are (or at least should be) preserved
when linking.

- Andrew Schwartzmeyer


On May 8, 2018, 7:28 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67025/
> -----------------------------------------------------------
> 
> (Updated May 8, 2018, 7:28 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the link order for gRPC in CMake.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 0075c133ef60bfef06f4123c14cae8a5672440f5 
> 
> 
> Diff: https://reviews.apache.org/r/67025/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ninja check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message