mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 66815: Removed an unconditional .get() in DefaultExecutor.
Date Thu, 26 Apr 2018 15:24:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Bugs: MESOS-8797
    https://issues.apache.org/jira/browse/MESOS-8797


Repository: mesos


Description
-------

This would fail in some cases where the optional
message is `None`, e.g. when the container is in
killing state.


Diffs
-----

  src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 


Diff: https://reviews.apache.org/r/66815/diff/1/


Testing
-------

`./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0
--gtest_repeat=500 --gtest_break_on_failure`


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message