mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 66310: Passed on registrar when constructing resource provider manager.
Date Thu, 26 Apr 2018 12:39:38 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 26, 2018, 2:39 p.m.)

Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.


Explicitly tore down resource provider manager with the agent.

This prevents multiple resource provider managers from being active when
an agent is terminated (without being destructed) and reassigned from a
newly constructed one.

Bugs: MESOS-8735

Repository: mesos


In order to support recovering resource provider manager information
in the future, we need to adjust the construction of the manager to be
able to consume a registrar.

This patch lays the groundwork by adjusting interfaces and their
usage; we will make use of the passed on information in a following

Diffs (updated)

  src/resource_provider/manager.hpp bc017fa3998b780cec82718cabe2a8b470a66db2 
  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
  src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b 
  src/slave/slave.cpp d0ff5f872433b3891b32e35aea6212bf45693ae5 
  src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea 




`make check`


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message