mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66545: Added admitted resource providers to the manager's registry.
Date Wed, 25 Apr 2018 10:56:01 GMT


> On April 25, 2018, 1:50 a.m., Chun-Hung Hsiao wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Line 851 (original), 851 (patched)
> > <https://reviews.apache.org/r/66545/diff/7/?file=2011120#file2011120line851>
> >
> >     Should we add a new test for `GenericRegistrar` recovery? We could do this in
another patch.

https://issues.apache.org/jira/browse/MESOS-8836.


> On April 25, 2018, 1:50 a.m., Chun-Hung Hsiao wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Line 889 (original), 894 (patched)
> > <https://reviews.apache.org/r/66545/diff/7/?file=2011120#file2011120line896>
> >
> >     Should we add a new test for `MasterRegistrar` recovery? We could do this in
another patch.

https://issues.apache.org/jira/browse/MESOS-8836


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66545/#review201878
-----------------------------------------------------------


On April 23, 2018, 1:19 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66545/
> -----------------------------------------------------------
> 
> (Updated April 23, 2018, 1:19 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8402
>     https://issues.apache.org/jira/browse/MESOS-8402
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added admitted resource providers to the manager's registry.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b 
>   src/resource_provider/registry.proto 14bd433ef056f8891e9a38153fdb06c39cee8f62 
>   src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea

> 
> 
> Diff: https://reviews.apache.org/r/66545/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message