mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.
Date Mon, 23 Apr 2018 12:15:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66546/#review201734
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66308', '66309', '66526', '66310', '66311', '66544', '66545', '66546']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546/logs/mesos-tests-stdout.log):

```
[----------] 9 tests from Endpoint/SlaveEndpointTest (1123 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (776 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (805 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (826 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (850 ms total)

[----------] Global test environment tear-down
[==========] 958 tests from 94 test cases ran. (462916 ms total)
[  PASSED  ] 956 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] ContentType/ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider/0,
where GetParam() = application/x-protobuf
[  FAILED  ] ContentType/ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider/1,
where GetParam() = application/json

 2 FAILED TESTS
  YOU HAVE 214 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546/logs/mesos-tests-stderr.log):

```
I0423 12:15:16.187870 23916 master.cpp:10453] Updating the state of task e0caaee7-d05a-4955-b18c-f517ab1d9fcc
of framework 844a1eb6-8781-4a83-bba3-b382cf383738-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
I0423 12:15:16.187870 12784 slave.cpp:3931] Shutting down framework 844a1eb6-8781-4a83-bba3-b382cf383738-0000
I0423 12:15:16.187870 12784 slave.cpp:6640] Shutting down executor 'e0caaee7-d05a-4955-b18c-f517abI0423
12:15:16.026840 29384 exec.cpp:162] Version: 1.6.0
I0423 12:15:16.054847 29712 exec.cpp:236] Executor registered on agent 844a1eb6-8781-4a83-bba3-b382cf383738-S0
I0423 12:15:16.058858 28484 executor.cpp:177] Received SUBSCRIBED event
I0423 12:15:16.063844 28484 executor.cpp:181] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0423 12:15:16.063844 28484 executor.cpp:177] Received LAUNCH event
I0423 12:15:16.067847 28484 executor.cpp:649] Starting task e0caaee7-d05a-4955-b18c-f517ab1d9fcc
I0423 12:15:16.146878 28484 executor.cpp:484] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I0423 12:15:16.158898 28484 executor.cpp:662] Forked command at 27808
I0423 12:15:16.190886 30656 exec.cpp:445] Executor asked to shutdown
I0423 12:15:16.190886 29256 executor.cpp:177] Received SHUTDOWN event
I0423 12:15:16.190886 29256 executor.cpp:759] Shutting down
I0423 12:15:16.190886 29256 executor.cpp:869] Sending SIGTERM to process tree at pid 1d9fcc'
of framework 844a1eb6-8781-4a83-bba3-b382cf383738-0000 at executor(1)@10.3.1.8:61555
I0423 12:15:16.189867 12784 slave.cpp:929] Agent terminating
W0423 12:15:16.189867 12784 slave.cpp:3927] Ignoring shutdown framework 844a1eb6-8781-4a83-bba3-b382cf383738-0000
because it is terminating
I0423 12:15:16.190886 23916 master.cpp:10552] Removing task e0caaee7-d05a-4955-b18c-f517ab1d9fcc
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework 844a1eb6-8781-4a83-bba3-b382cf383738-0000 on agent 844a1eb6-8781-4a83-bba3-b382cf383738-S0
at slave(428)@10.3.1.8:61534 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0423 12:15:16.193858 32028 containerizer.cpp:2375] Destroying container 630750e1-d788-4a8a-a9bf-71c8b408fb17
in RUNNING state
I0423 12:15:16.193858 32028 containerizer.cpp:2989] Transitioning the state of container 630750e1-d788-4a8a-a9bf-71c8b408fb17
from RUNNING to DESTROYING
I0423 12:15:16.193858 23916 master.cpp:1296] Agent 844a1eb6-8781-4a83-bba3-b382cf383738-S0
at slave(428)@10.3.1.8:61534 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I0423 12:15:16.194860 32028 launcher.cpp:156] Asked to destroy container 630750e1-d788-4a8a-a9bf-71c8b408fb17
I0423 12:15:16.194860 23916 master.cpp:3287] Disconnecting agent 844a1eb6-8781-4a83-bba3-b382cf383738-S0
at slave(428)@10.3.1.8:61534 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0423 12:15:16.194860 28456 hierarchical.cpp:344] Removed framework 844a1eb6-8781-4a83-bba3-b382cf383738-0000
I0423 12:15:16.194860 23916 master.cpp:3306] Deactivating agent 844a1eb6-8781-4a83-bba3-b382cf383738-S0
at slave(428)@10.3.1.8:61534 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0423 12:15:16.194860 32208 hierarchical.cpp:766] Agent 844a1eb6-8781-4a83-bba3-b382cf383738-S0
deactivated
I0423 12:15:16.290858 27248 containerizer.cpp:2828] Container 630750e1-d788-4a8a-a9bf-71c8b408fb17
has exited
I0423 12:15:16.322857 28812 master.cpp:1138] Master terminating
I0423 12:15:16.325855 27248 hierarchical.cpp:609] Removed agent 844a1eb6-8781-4a83-bba3-b382cf383738-S0
I0423 12:15:16.831871 31272 process.cpp:939] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 12, 2018, 9:48 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66546/
> -----------------------------------------------------------
> 
> (Updated April 12, 2018, 9:48 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-7558
>     https://issues.apache.org/jira/browse/MESOS-7558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a check to the resource provider manager's subscribe
> functionality making sure that any the ID sent by a resubscribing
> resource provider corresponds to some previously known resource
> provider.
> 
> This not only serves as convenient validation of user-provided data,
> but also makes sure that the internal state of the resource provider
> manager remains consistent.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea

> 
> 
> Diff: https://reviews.apache.org/r/66546/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message