mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <>
Subject Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.
Date Fri, 20 Apr 2018 23:15:43 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 20, 2018, 4:15 p.m.)

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Review comments.

Bugs: MESOS-4965

Repository: mesos


These two operations are intended to be non-speculative eventually but
are implemented as speculative right now. To avoid frameworks opt-in to
dangerous behavior, we require that accept can only contain one
`GROW_VOLUME` or `SHRINK_VOLUME` and no other operations.

This is implemented by reuse existing code which already drops `LAUNCH`
or `LAUNCH_GROUP` with proper reason and message.

Diffs (updated)

  src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 




Behavior tested in


Zhitao Li

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message