mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 66700: Changed call from os::shell() to os::system().
Date Wed, 18 Apr 2018 20:56:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66700/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

The function os::shell is not implemented on Windows,
making it necessary to either hide all calls behind a
preprocessor macro or to avoid the function.


Diffs
-----

  3rdparty/libprocess/src/memory_profiler.cpp b2174ba8ce9f10b268736678e3d92b175f6d1247 


Diff: https://reviews.apache.org/r/66700/diff/1/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message