mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
Date Mon, 19 Mar 2018 17:30:21 GMT


> On March 19, 2018, 9:50 a.m., Zhitao Li wrote:
> > src/master/master.cpp
> > Lines 5969 (patched)
> > <https://reviews.apache.org/r/64618/diff/8/?file=1975984#file1975984line5970>
> >
> >     whitespace after block
> >     
> >     `const UUID& ...`

This one is moved at the end of the function, so it can't be a const ref.


> On March 19, 2018, 9:50 a.m., Zhitao Li wrote:
> > src/master/master.cpp
> > Lines 5972 (patched)
> > <https://reviews.apache.org/r/64618/diff/8/?file=1975984#file1975984line5973>
> >
> >     How is this CHECK validated/ensured?

`Framework::operations` and `Framework::operationUUIDs` should be kept in-sync by `Framework::addOperation()`
and `Framework::removeOperation()`.

I just noticed that `Framework::removeOperation()` doesn't remove the operation from `Framework::operationUUIDs`,
which is a bug. I'll post a patch fixing this.


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199426
-----------------------------------------------------------


On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> -----------------------------------------------------------
> 
> (Updated March 16, 2018, 12:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
>     https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/8/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message