mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhi...@apache.org>
Subject Re: Review Request 66060: Added end-to-end tests for operation feedback.
Date Mon, 19 Mar 2018 17:12:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66060/#review199431
-----------------------------------------------------------




src/tests/storage_local_resource_provider_tests.cpp
Lines 3282 (patched)
<https://reviews.apache.org/r/66060/#comment279755>

    Is there a reason this test requires `ROOT_` filter? A lot of people do not run such tests
by default with `make check` so we could reduce coverage.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3411 (patched)
<https://reviews.apache.org/r/66060/#comment279758>

    empty line after `foreach` block



src/tests/storage_local_resource_provider_tests.cpp
Lines 3604 (patched)
<https://reviews.apache.org/r/66060/#comment279759>

    Where is this magic string `"operation"` come from? Can we define a local const?


- Zhitao Li


On March 16, 2018, 12:58 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66060/
> -----------------------------------------------------------
> 
> (Updated March 16, 2018, 12:58 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-8201
>     https://issues.apache.org/jira/browse/MESOS-8201
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added end-to-end tests for operation feedback.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 264d42b57fe1a8ea04c1de0a10112878c7b45d39

> 
> 
> Diff: https://reviews.apache.org/r/66060/diff/1/
> 
> 
> Testing
> -------
> 
> The tests passed over 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message