mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66115: Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`.
Date Mon, 19 Mar 2018 12:35:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66115/#review199409
-----------------------------------------------------------



I am not convinced that this tool will be much more useful than e.g., the existing `support/mesos-tidy.sh`.
While being able to generate compilation databases and generating prerequisites is great,
this tool e.g., would not enforce a proper header filter which would only diagnose cpp files
for the uninitiated. Would the idea be to increase mesos-tidy coverage by having it run outside
of the one docker environment `mesos-tidy.sh` provides?

- Benjamin Bannier


On March 16, 2018, 11:57 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66115/
> -----------------------------------------------------------
> 
> (Updated March 16, 2018, 11:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `mesos-tidy.py`, a modified version of `run-clang-tidy.py`.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66115/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message