mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <>
Subject Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.
Date Fri, 16 Mar 2018 19:07:19 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 16, 2018, 12:07 p.m.)

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Patch updated. Thanks for the informative review.

Bugs: MESOS-8611

Repository: mesos


Directly invoking unmock calls in the test process can potentially
cause races with the real mock slave process. It is more robust to
dispatch the unmock calls to the real mock slave process.

Also added several mock expectations to avoid "uninteresting mock
call" test warnings.

Diffs (updated)

  src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 




`./bin/ --gtest_filter=*SlaveTest* --gtest_repeat=-1 --gtest_break_on_failure`
runs forever :)


Meng Zhu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message