mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Review Request 65955: Fixed implicit conversion warnings.
Date Wed, 07 Mar 2018 18:45:31 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Jie Yu, James Peach, and Zhitao Li.

Repository: mesos


This patch fixes three new "possible loss of data" implicit conversion
warnings by using `static_cast` to the RHS type.


  src/docker/docker.cpp bb81c4d68df95b0ccb2a0830e651c75f4493752e 
  src/slave/containerizer/fetcher.cpp a49411b7bac2d5a50a75d0b802842c2f61fe58c6 
  src/slave/containerizer/mesos/containerizer.cpp a61ed5bb4f60ec63aebd6bdabbc9a4b01235623e



Ninja build on Linux annd VS build on Windows. Warnings gone AFAICT.

We really need to turn on conversion warnings on the Linux build. Do any of you know how?
Until we do, I'm hesitant to add -Werror to the Windows build.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message