mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <>
Subject Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion.
Date Tue, 06 Mar 2018 09:29:12 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 6, 2018, 5:29 p.m.)

Review request for mesos, Anand Mazumdar, Benjamin Mahler, Chun-Hung Hsiao, and Zhitao Li.


Addressed review comments.

Summary (updated)

Added protobuf map support to stout JSON<->protobuf conversion.

Bugs: MESOS-7656

Repository: mesos

Description (updated)

Map is a feature of proto2 syntax, but it can only be compiled
with 3.0.0+ protobuf compiler, see the following discussion for

We have already upgraded the compiler from 2.6.1 to 3.3.0 in
MESOS-7228. This patch adds map support in the json <-> protobuf
conversion in stout.

Diffs (updated)

  3rdparty/stout/include/stout/protobuf.hpp 4a1605e5130dbf7e8286dbb43d0d04ab4394e79a 





Qian Zhang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message