mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 65795: Adding warning to `apply-reviews.py` for previously submitted patches.
Date Wed, 28 Feb 2018 22:32:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/#review198417
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for your contribution!


support/apply-reviews.py
Lines 113-114 (patched)
<https://reviews.apache.org/r/65795/#comment278546>

    The space between "already" and "been" should be moved to line 114 to be consistent with
the style of the other messages.


- Gaston Kleiman


On Feb. 24, 2018, 5:36 p.m., Shubham Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65795/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2018, 5:36 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8586
>     https://issues.apache.org/jira/browse/MESOS-8586
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit emits a warning when a chain skips submitted patches so
> that the user is aware they were ignored.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53 
> 
> 
> Diff: https://reviews.apache.org/r/65795/diff/1/
> 
> 
> Testing
> -------
> 
> Test done.
> 
> command: ./support/apply-reviews.py -c -r 65397
> output: Warning: Review 65397 has already been applied
> 
> 
> Thanks,
> 
> Shubham Kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message