mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.
Date Wed, 28 Feb 2018 01:04:27 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 28, 2018, 1:04 a.m.)

Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.

Bugs: MESOS-8576

Repository: mesos


Because the Docker library did not immediately transition the
Future returned by `inspect()` to DISCARDED, it was safe for the
Docker containerizer to discard this Future before failing the
Promise associated with the Future returned by `launch()`.

However, the introduction of an `onDiscard` callback in
`Docker::inspect()` makes this assumption invalid. This patch
addresses this by failing the Promise before discarding the


  src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564 



`sudo make check`


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message