mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.
Date Fri, 23 Feb 2018 23:20:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198226
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5259-5267 (patched)
<https://reviews.apache.org/r/65750/#comment278339>

    Should we just do:
    
    ```
      TaskInfo task = createTask(
          offer.slave_id(),
          offer.resources(),
          SLEEP_COMMAND(1000));
    ```


- Gilbert Song


On Feb. 23, 2018, 2:41 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2018, 2:41 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for a hung 'docker inspect' during container pull.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99

> 
> 
> Diff: https://reviews.apache.org/r/65750/diff/3/
> 
> 
> Testing
> -------
> 
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message