mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <>
Subject Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.
Date Tue, 20 Feb 2018 15:18:59 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Alexander Rukletsov, Gilbert Song, and Greg Mann.

Bugs: MESOS-8574

Repository: mesos


Previosly, if `docker inspect` command hanged, the docker container
ended up in an unkillable state. This patch adds a timeout for inspect
command after receiving `killTask` analogically to `reaped` handler.
In addition we've added a timeout for `docker stop` command. If docker
`stop` or `inspect` command times out, we discard the related future,
thus the docker library kills previously spawned docker cli subprocess.
As a result, a scheduler can retry `killTask` operation to handle
nasty docker bugs that lead to hanging docker cli.


  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 




Andrei Budnik

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message