mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <>
Subject Re: Review Request 65518: Reaped the container process directly in Docker executor.
Date Tue, 13 Feb 2018 03:20:07 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 13, 2018, 11:20 a.m.)

Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod Kone.


Addressed review comments.

Bugs: MESOS-8488

Repository: mesos

Description (updated)

Due to a Docker issue (,
Docker daemon can fail to catch a container exit, i.e., the container
process has already exited but the command `docker ps` shows the
container still running, this will lead to the "docker run" command
that we execute in Docker executor never returning, and it will also
cause the `docker stop` command takes no effect, i.e., it will return
without error but `docker ps` shows the container still running, so
the task will stuck in `TASK_KILLING` state.

To workaround this Docker issue, in this patch we made Docker executor
reaps the container process directly so Docker executor will be notified
once the container process exits.

Diffs (updated)

  src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a 




sudo make check


Qian Zhang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message