mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <>
Subject Re: Review Request 65449: Fixed an bug where executor info lingers on master if failed to launch.
Date Tue, 13 Feb 2018 00:11:24 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 12, 2018, 4:11 p.m.)

Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.


`"Executor" +  executor->state` was complained on Mac, changed it to plain string.

Bugs: MESOS-1720

Repository: mesos


Master relies on `ExitedExecutorMessage` from the agent to recycle
executor entry. However, this message won't be sent if the executor
never actually launched (due to transient error), leaving executor
info on the master lingering and resource claimed.
See MESOS-1720.

This patch fixes this issue by sending the `ExitedExecutorMessage`
from the agent if the executor is never launched.

Diffs (updated)

  src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
  src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5 
  src/tests/mock_slave.hpp 942ead57fc67bdd2a268c67575952349838dc280 
  src/tests/mock_slave.cpp 597d7abef20dd5f89b16e4616233f02760b9d037 
  src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 




make check
Dedicated test in #65448


Meng Zhu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message