mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 65503: Added bootstrap-table library for the WebUI.
Date Sun, 11 Feb 2018 16:15:12 GMT


> On Feb. 6, 2018, 3:26 a.m., Benjamin Mahler wrote:
> > Looks good, couple of questions:
> > 
> > (1) Doesn't this need to be part of the installation? I think you need to update
the autotools and cmake builds?
> > (2) Do we need to update LICENSE to include this new sub-component?

1) Correct, I have modified `src/Makefile.am` in the new revision. No `CMakeLists.txt` file
needs to be updated.
2) This is currently not done for JS libraries (I have checked for Angular). Should we do
it for all our JS libraries in another patch?


- Armand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/#review196858
-----------------------------------------------------------


On Feb. 11, 2018, 4:15 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65503/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2018, 4:15 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8486
>     https://issues.apache.org/jira/browse/MESOS-8486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This library extends the properties of the tables provided by Bootstrap.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151 
>   src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION 
>   src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION 
>   src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION 
>   support/mesos-style.py d9e83d7c0cf6146f00ce7f1ab11b89880d105984 
> 
> 
> Diff: https://reviews.apache.org/r/65503/diff/2/
> 
> 
> Testing
> -------
> 
> Tested in the dependent review request /r/65346/
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message