mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 65402: Windows: Used Unicode API to duplicate sockets.
Date Wed, 07 Feb 2018 19:22:03 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 7, 2018, 11:22 a.m.)

Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.

Summary (updated)

Windows: Used Unicode API to duplicate sockets.

Repository: mesos


The CRT API for duplicating file handles is left as-is because
`WindowsFD` currently gets a CRT `int` file descriptor, which
necessitates using `_dup` instead of `DuplicateHandle`. Furthermore, the
latter API does not appear compatible with handles used to redirect
stdout/stderr/stdin for subprocesses.

Diffs (updated)

  3rdparty/stout/include/stout/os/windows/dup.hpp b37aaa6429e0e7b4340e86c078f5c543e443bdcd





Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message