mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.
Date Tue, 06 Feb 2018 23:05:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/#review196941
-----------------------------------------------------------




src/tests/cluster.cpp
Lines 685 (patched)
<https://reviews.apache.org/r/65060/#comment276931>

    Can we move to the SLRP test fixture? I don't think it's maintainable to have all cleanup
code in a single place.
    
    For instance, CNI test cleanup code is very networking related, better to put in CNI test
fixtures, not in a global location.


- Jie Yu


On Feb. 3, 2018, 1:37 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65060/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2018, 1:37 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8427
>     https://issues.apache.org/jira/browse/MESOS-8427
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up endpoint directories after SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.cpp 19a41c7c1c303ad806daa4e5e3765a1e0b55933b 
> 
> 
> Diff: https://reviews.apache.org/r/65060/diff/5/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message