mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 65397: Windows: Fixed `fs::list` to return full paths.
Date Tue, 06 Feb 2018 21:18:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65397/#review196730
-----------------------------------------------------------


Ship it!




LGTM.

- Joseph Wu


On Jan. 29, 2018, 12:32 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65397/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2018, 12:32 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-7803
>     https://issues.apache.org/jira/browse/MESOS-7803
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This resolves MESOS-7803, where `fs::list` only returned the name of the
> found files, dropping the initial path components. That is, for a
> directory `foo` with the file `bar` in it, and the pattern
> `fs::list("foo/*")`, it was incorrectly returning just `bar`, not
> `foo/bar`. This was fixed by getting the `dirname` of the pattern, and
> rejoining it with each found file name before it is returned.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows/fs.hpp bc7cf025c9228a65f2ae0fab9ba27b386d189b46

> 
> 
> Diff: https://reviews.apache.org/r/65397/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message