mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 65521: Improved isolation for agent RP API config tests.
Date Tue, 06 Feb 2018 19:46:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65521/#review196921
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 6, 2018, 4:11 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65521/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2018, 4:11 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the tests to use a unique cgroup for each run. It also
> changes `CHECK_*` macros to `ASSERT_*` so the tests can be torn down
> properly upon assertion failures.
> 
> 
> Diffs
> -----
> 
>   src/tests/agent_resource_provider_config_api_tests.cpp 7cbee5cceef2963b736f3e6ce3f52fcf0b3c029c

> 
> 
> Diff: https://reviews.apache.org/r/65521/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message