mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65523: Fixed a bug in the SLRP metrics test.
Date Tue, 06 Feb 2018 04:58:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65523/#review196864
-----------------------------------------------------------




src/tests/storage_local_resource_provider_tests.cpp
Line 2915 (original), 2915 (patched)
<https://reviews.apache.org/r/65523/#comment276740>

    This is also not required.


- Chun-Hung Hsiao


On Feb. 6, 2018, 4:10 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65523/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2018, 4:10 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The metrics test unnecessarily set up the disk profile module without
> providing the profile config file. This may cause the profile module to
> pull a non-existent file.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386

> 
> 
> Diff: https://reviews.apache.org/r/65523/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message