mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65515: Added rvalue reference Try::get overloads.
Date Mon, 05 Feb 2018 22:47:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65515/#review196839
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65334', '65514', '65515']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65515

Relevant logs:

- [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65515/logs/stout-tests-cmake-stdout.log):

```
         D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2\user\win32\userinfo.c(101):
warning C4133: 'function': incompatible types - from 'char [520]' to 'LPCWSTR' [D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2-build\libapr-1.vcxproj]
[D:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
         D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2\user\win32\userinfo.c(227):
warning C4133: 'function': incompatible types - from 'char *' to 'LPCWSTR' [D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2-build\libapr-1.vcxproj]
[D:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
         D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2\user\win32\userinfo.c(227):
warning C4133: 'function': incompatible types - from 'const char *' to 'LPCWSTR' [D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2-build\libapr-1.vcxproj]
[D:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
         D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2\user\win32\userinfo.c(228):
warning C4133: 'function': incompatible types - from 'char [256]' to 'LPWSTR' [D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2-build\libapr-1.vcxproj]
[D:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
         D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2\user\win32\userinfo.c(234):
warning C4133: 'function': incompatible types - from 'char *' to 'LPCWSTR' [D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2-build\libapr-1.vcxproj]
[D:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
         D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2\user\win32\userinfo.c(234):
warning C4133: 'function': incompatible types - from 'const char *' to 'LPCWSTR' [D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2-build\libapr-1.vcxproj]
[D:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
         D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2\user\win32\userinfo.c(235):
warning C4133: 'function': incompatible types - from 'char [256]' to 'LPWSTR' [D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2-build\libapr-1.vcxproj]
[D:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
         D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2\user\win32\userinfo.c(259):
warning C4133: 'function': incompatible types - from 'char [260]' to 'LPWSTR' [D:\DCOS\mesos\3rdparty\libapr-1.5.2\src\libapr-1.5.2-build\libapr-1.vcxproj]
[D:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj" (default target) (10) ->
         CUSTOMBUILD : CMake warning :  [D:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj" (default target) (5) ->
         CUSTOMBUILD : CMake warning :  [D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       (ClCompile target) -> 
         D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/try.hpp(98): error C2102: '&'
requires l-value (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\ip_tests.cpp)
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
         D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/try.hpp(98): error C2102: '&'
requires l-value (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp)
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]

    114 Warning(s)
    2 Error(s)

Time Elapsed 00:03:40.14
```

- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65515/logs/libprocess-tests-cmake-stdout.log):

```
         D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401):
warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target)
(1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (3)
->
       "D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj" (default target) (15) ->
         CUSTOMBUILD : CMake warning :  [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target)
(1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (3)
->
       "D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) (10) ->
       (ClCompile target) -> 
         D:\DCOS\mesos\mesos\3rdparty\libprocess\src\jwt.cpp(144): warning C4244: 'initializing':
conversion from 'double' to 'int64_t', possible loss of data [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
         D:\DCOS\mesos\mesos\3rdparty\libprocess\src\jwt.cpp(144): warning C4244: 'initializing':
conversion from 'double' to 'const int64_t', possible loss of data [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
         D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp(363): warning C4267:
'argument': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
         D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp(595): warning
C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target)
(1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (3)
->
       "D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) (10) ->
       (ClCompile target) -> 
         D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/try.hpp(98): error C2102: '&'
requires l-value (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\process.cpp)
[D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]

    23 Warning(s)
    1 Error(s)

Time Elapsed 00:04:37.62
```

- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65515/logs/mesos-tests-cmake-stdout.log):

```
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3091):
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426):
warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS
to disable deprecated API warningsd:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205)
: warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543):
warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548):
warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569):
warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (10) ->
       "D:\DCOS\mesos\src\slave\containerizer\mesos\mesos-containerizer.vcxproj" (default
target) (16) ->
       "D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) (22) ->
       (ClCompile target) -> 
         D:\DCOS\mesos\mesos\3rdparty\stout\include\stout/try.hpp(98): error C2102: '&'
requires l-value [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]

    170 Warning(s)
    1 Error(s)

Time Elapsed 00:06:24.33
```

- Mesos Reviewbot Windows


On Feb. 5, 2018, 10:08 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65515/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2018, 10:08 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-2664
>     https://issues.apache.org/jira/browse/MESOS-2664
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/try.hpp 90f8aed56ce5d77e70af9e516faad152083d1488 
> 
> 
> Diff: https://reviews.apache.org/r/65515/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message