mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 64211: Added options to build the Python CLI and run unit tests.
Date Sun, 04 Feb 2018 18:07:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/
-----------------------------------------------------------

(Updated Feb. 4, 2018, 6:07 p.m.)


Review request for mesos, Benjamin Bannier and Kevin Klues.


Changes
-------

Added CMake option.


Bugs: MESOS-8240
    https://issues.apache.org/jira/browse/MESOS-8240


Repository: mesos


Description
-------

An update of the discarded review /r/52543.

Works with Autotools and CMake.


Diffs (updated)
-----

  cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
  cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e 
  configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507 
  docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
  src/CMakeLists.txt 21fb47e29dd0b19681690b8de5261c68b574a7c8 
  src/Makefile.am e444b8981093ba6f4e94acb7a060b998f75b542a 
  src/python/cli_new/CMakeLists.txt PRE-CREATION 
  src/python/cli_new/tests/CMakeLists.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/64211/diff/3/

Changes: https://reviews.apache.org/r/64211/diff/2-3/


Testing (updated)
-------

Testing done on Fedora 25.

For Autotools:
```
$ ./bootstrap
$ mkdir build
$ cd build
$ ../configure --enable-new-cli --disable-java
$ make check
```

For CMake:
```
$ ./bootstrap
$ mkdir build
$ cd build
$ cmake .. -DENABLE_NEW_CLI=1
$ cmake --build . -- -j16
```

Checked that the the CLI tests were run, that the content of the directory `build/src/cli`
was as expected, and that `build/src/mesos/mesos` was correctly running.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message