mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65447: Refactored couple of launch task sanity checks into a single code path.
Date Fri, 02 Feb 2018 23:28:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65447/#review196739
-----------------------------------------------------------




src/slave/slave.cpp
Line 2033 (original), 2033 (patched)
<https://reviews.apache.org/r/65447/#comment276571>

    Most of our member function names start with verbs. Maybe `checkXXXXX`? Also we cannot
tell what kind of invariants are checked from the name.



src/slave/slave.cpp
Lines 2071-2079 (original), 2056-2064 (patched)
<https://reviews.apache.org/r/65447/#comment276569>

    Agreed. This confuses me a bit because before going through the code, I didn't know why
we need to do the same check in `_run` and its continuation.



src/slave/slave.cpp
Lines 2196-2197 (original), 2213-2214 (patched)
<https://reviews.apache.org/r/65447/#comment276597>

    http://mesos.apache.org/documentation/latest/c++-style-guide/#function-definition-invocation


- Chun-Hung Hsiao


On Feb. 1, 2018, 2:03 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65447/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2018, 2:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initial steps common to `_run()` and `__run()` on the task launch
> code path are refactored.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65447/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message