mesos-reviews mailing list archives: January 2018

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · Next »Thread · Author · Date
Armand Grillet Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. Fri, 26 Jan, 15:16
Mesos Reviewbot Windows   Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. Fri, 26 Jan, 16:45
Mesos Reviewbot Windows   Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. Fri, 26 Jan, 17:33
Benjamin Mahler   Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. Sat, 27 Jan, 02:22
Armand Grillet     Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. Mon, 29 Jan, 09:32
Benjamin Mahler   Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. Mon, 29 Jan, 19:25
Benno Evers Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount. Fri, 26 Jan, 18:12
Benno Evers   Re: Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount. Fri, 26 Jan, 18:12
Mesos Reviewbot Windows     Re: Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount. Fri, 26 Jan, 19:10
Mesos Reviewbot Windows     Re: Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount. Fri, 26 Jan, 20:00
Gaston Kleiman Review Request 65357: Made devolving `v1::scheduler::Call::SUBSCRIBE` more robust. Fri, 26 Jan, 22:08
Greg Mann   Re: Review Request 65357: Made devolving `v1::scheduler::Call::SUBSCRIBE` more robust. Mon, 29 Jan, 21:26
Gaston Kleiman Review Request 65359: Added an extra CHECK to `Master::acknowledge()`. Fri, 26 Jan, 22:08
Greg Mann   Re: Review Request 65359: Added an extra CHECK to `Master::acknowledge()`. Mon, 29 Jan, 21:33
Gaston Kleiman Review Request 65358: Removed unnecesssary validations from `Master::receive()`. Fri, 26 Jan, 22:08
Greg Mann   Re: Review Request 65358: Removed unnecesssary validations from `Master::receive()`. Mon, 29 Jan, 21:29
Gaston Kleiman Review Request 65360: Made `master::receive()` drop `ACKNOWLEDGE_OPERATION_STATUS` calls. Fri, 26 Jan, 22:08
Greg Mann   Re: Review Request 65360: Made `master::receive()` drop `ACKNOWLEDGE_OPERATION_STATUS` calls. Wed, 31 Jan, 20:50
Gaston Kleiman Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls. Fri, 26 Jan, 22:08
Gaston Kleiman   Re: Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls. Mon, 29 Jan, 22:09
Greg Mann     Re: Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls. Mon, 29 Jan, 23:33
Greg Mann     Re: Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls. Wed, 31 Jan, 20:53
Gaston Kleiman Review Request 65362: Added a method to increment invalid scheduler API call counters. Fri, 26 Jan, 22:08
Greg Mann   Re: Review Request 65362: Added a method to increment invalid scheduler API call counters. Tue, 30 Jan, 19:33
Gaston Kleiman   Re: Review Request 65362: Added a method to increment invalid scheduler API call counters. Tue, 30 Jan, 21:21
Gaston Kleiman Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls. Fri, 26 Jan, 22:08
Joseph Wu Review Request 65366: Added test for maintenance-related offer rescinding behavior. Sat, 27 Jan, 01:40
Benjamin Mahler   Re: Review Request 65366: Added test for maintenance-related offer rescinding behavior. Mon, 29 Jan, 05:01
Joseph Wu Review Request 65367: Added equality operator for Unavailability protobuf. Sat, 27 Jan, 01:40
Benjamin Mahler   Re: Review Request 65367: Added equality operator for Unavailability protobuf. Sat, 27 Jan, 02:53
Joseph Wu Review Request 65368: Updated maintenance schedule logic. Sat, 27 Jan, 01:40
Mesos Reviewbot Windows   Re: Review Request 65368: Updated maintenance schedule logic. Sat, 27 Jan, 02:42
Mesos Reviewbot Windows   Re: Review Request 65368: Updated maintenance schedule logic. Sat, 27 Jan, 03:32
Benjamin Mahler   Re: Review Request 65368: Updated maintenance schedule logic. Mon, 29 Jan, 05:22
Meng Zhu Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill. Sat, 27 Jan, 02:06
Mesos Reviewbot Windows   Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill. Sun, 28 Jan, 11:00
Mesos Reviewbot Windows   Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill. Sun, 28 Jan, 11:44
Benjamin Mahler   Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill. Tue, 30 Jan, 23:10
Michael Park Review Request 65372: Replaced the `Os.Which` test to use `cat` rather than `ping`. Sun, 28 Jan, 21:48
Till Toenshoff   Re: Review Request 65372: Replaced the `Os.Which` test to use `cat` rather than `ping`. Sun, 28 Jan, 22:05
Mesos Reviewbot Windows   Re: Review Request 65372: Replaced the `Os.Which` test to use `cat` rather than `ping`. Sun, 28 Jan, 22:39
Benjamin Mahler Review Request 65375: Added move construction and assignment to Future. Mon, 29 Jan, 02:29
Mesos Reviewbot Windows   Re: Review Request 65375: Added move construction and assignment to Future. Mon, 29 Jan, 03:17
Michael Park   Re: Review Request 65375: Added move construction and assignment to Future. Mon, 29 Jan, 03:45
Mesos Reviewbot Windows   Re: Review Request 65375: Added move construction and assignment to Future. Mon, 29 Jan, 04:05
Michael Park Review Request 65376: Reverted `protobuf::read(path)` to return `Result<T>`. Mon, 29 Jan, 07:55
Gilbert Song   Re: Review Request 65376: Reverted `protobuf::read(path)` to return `Result<T>`. Mon, 29 Jan, 08:19
Chun-Hung Hsiao   Re: Review Request 65376: Reverted `protobuf::read(path)` to return `Result<T>`. Mon, 29 Jan, 19:55
Michael Park Review Request 65377: Updated `state::read` to return `Result`. Mon, 29 Jan, 07:55
Gilbert Song   Re: Review Request 65377: Updated `state::read` to return `Result`. Mon, 29 Jan, 08:22
Chun-Hung Hsiao   Re: Review Request 65377: Updated `state::read` to return `Result`. Mon, 29 Jan, 22:23
Michael Park Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. Mon, 29 Jan, 07:55
Gilbert Song   Re: Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. Mon, 29 Jan, 08:23
Mesos Reviewbot Windows   Re: Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. Mon, 29 Jan, 08:47
Mesos Reviewbot Windows   Re: Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. Mon, 29 Jan, 09:35
Mesos Reviewbot Windows   Re: Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. Mon, 29 Jan, 10:03
Mesos Reviewbot Windows   Re: Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. Mon, 29 Jan, 12:04
Mesos Reviewbot Windows   Re: Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. Mon, 29 Jan, 12:55
Chun-Hung Hsiao   Re: Review Request 65378: Reverted the uses of `state::read` since it returns `Result`. Mon, 29 Jan, 22:56
Qian Zhang Review Request 65382: Not reap Docker executor when the container has exited. Mon, 29 Jan, 13:15
Qian Zhang   Re: Review Request 65382: Reaped Docker executor only when it can be connected. Tue, 30 Jan, 15:35
Qian Zhang     Re: Review Request 65382: Reaped Docker executor only when it can be connected. Tue, 30 Jan, 15:42
Vinod Kone       Re: Review Request 65382: Reaped Docker executor only when it can be connected. Tue, 30 Jan, 22:25
Qian Zhang         Re: Review Request 65382: Reaped Docker executor only when it can be connected. Wed, 31 Jan, 01:14
Vinod Kone       Re: Review Request 65382: Reaped Docker executor only when it can be connected. Tue, 30 Jan, 22:26
Qian Zhang         Re: Review Request 65382: Reaped Docker executor only when it can be connected. Wed, 31 Jan, 01:16
Qian Zhang       Re: Review Request 65382: Reaped Docker executor only when it can be connected. Wed, 31 Jan, 01:14
Qian Zhang Review Request 65383: Recovered the executor pid in Docker containerizer. Mon, 29 Jan, 13:16
Qian Zhang Review Request 65384: Fixed a coding error in a log message of Docker containerizer. Mon, 29 Jan, 13:18
Mesos Reviewbot Windows   Re: Review Request 65384: Fixed a coding error in a log message of Docker containerizer. Mon, 29 Jan, 14:08
Qian Zhang   Re: Review Request 65384: Fixed a coding error in a log message of Docker containerizer. Tue, 30 Jan, 15:37
Qian Zhang     Re: Review Request 65384: Fixed a coding error in a log message of Docker containerizer. Tue, 30 Jan, 15:40
James Peach Review Request 65391: Added a UTS namespace isolator. Mon, 29 Jan, 18:18
James Peach   Re: Review Request 65391: Added a UTS namespace isolator. Tue, 30 Jan, 00:05
James DeFelice     Re: Review Request 65391: Added a UTS namespace isolator. Tue, 30 Jan, 20:19
James Peach Review Request 65392: Document the namespace/uts isolator. Mon, 29 Jan, 18:19
Mesos Reviewbot Windows   Re: Review Request 65392: Document the namespace/uts isolator. Mon, 29 Jan, 19:06
Mesos Reviewbot Windows   Re: Review Request 65392: Document the namespace/uts isolator. Tue, 30 Jan, 00:58
James DeFelice   Re: Review Request 65392: Document the namespace/uts isolator. Tue, 30 Jan, 20:21
Akash Gupta Review Request 65393: Fixed docker command health check to use the right docker socket. Mon, 29 Jan, 18:20
Mesos Reviewbot Windows   Re: Review Request 65393: Fixed docker command health check to use the right docker socket. Mon, 29 Jan, 19:09
Andrew Schwartzmeyer   Re: Review Request 65393: Fixed docker command health check to use the right docker socket. Mon, 29 Jan, 21:00
Akash Gupta     Re: Review Request 65393: Fixed docker command health check to use the right docker socket. Mon, 29 Jan, 21:04
Andrew Schwartzmeyer   Re: Review Request 65393: Fixed docker command health check to use the right docker socket. Mon, 29 Jan, 22:43
Akash Gupta Review Request 65396: Moved docker command check code inside health check library. Mon, 29 Jan, 18:21
Akash Gupta Review Request 65395: Refactored health checks to cleanly separate each different check. Mon, 29 Jan, 18:26
Akash Gupta   Re: Review Request 65395: Refactored health checks to cleanly separate each different check. Tue, 30 Jan, 10:06
Akash Gupta Review Request 65394: Added separate structs for health check runtime and check types. Mon, 29 Jan, 18:38
Akash Gupta   Re: Review Request 65394: Added separate structs for health check runtime and check types. Mon, 29 Jan, 23:48
Akash Gupta   Re: Review Request 65394: Added separate structs for health check runtime and check types. Tue, 30 Jan, 10:05
Andrew Schwartzmeyer Review Request 65397: Windows: Fixed `fs::list` to return full paths. Mon, 29 Jan, 20:32
Andrew Schwartzmeyer Review Request 65398: Removed workaround in ZooKeeper test. Mon, 29 Jan, 20:32
Andrew Schwartzmeyer Review Request 65399: Windows: Moved "kill on close" job object flag to own function. Mon, 29 Jan, 20:34
Andrew Schwartzmeyer Review Request 65400: Windows: Tied task lifetimes to executors. Mon, 29 Jan, 20:34
Andrew Schwartzmeyer Review Request 65401: Windows: Enabled `Flags::runtime_directory` for checkpointing. Mon, 29 Jan, 20:35
Andrew Schwartzmeyer Review Request 65402: Windows: Use Unicode API to duplicate sockets. Mon, 29 Jan, 20:35
Andrew Schwartzmeyer Review Request 65403: Windows: Implemented `os::cloexec` family for file descriptors. Mon, 29 Jan, 20:35
Andrew Schwartzmeyer   Re: Review Request 65403: Windows: Implemented `os::cloexec` family for file descriptors. Mon, 29 Jan, 20:37
Andrew Schwartzmeyer Review Request 65404: Windows: Commented `O_CLOEXEC` mapping in `open.hpp`. Mon, 29 Jan, 20:38
Andrew Schwartzmeyer Review Request 65405: Implemented `net::socket()` for Windows using `WSASocket`. Mon, 29 Jan, 20:39
Andrew Schwartzmeyer   Re: Review Request 65405: Implemented `net::socket()` for Windows using `WSASocket`. Mon, 29 Jan, 20:39
Andrew Schwartzmeyer Review Request 65406: Added `TYPED_TEST_TEMP_DISABLED_ON_WINDOWS` macro. Mon, 29 Jan, 20:39
Andrew Schwartzmeyer Review Request 65407: Windows: Enabled tests that were blocked by MESOS-7604. Mon, 29 Jan, 20:40
Andrew Schwartzmeyer Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`. Mon, 29 Jan, 20:40
Mesos Reviewbot Windows   Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`. Mon, 29 Jan, 21:28
Andrew Schwartzmeyer     Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`. Mon, 29 Jan, 21:33
Andrew Schwartzmeyer Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`. Mon, 29 Jan, 20:41
Gaston Kleiman   Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`. Mon, 29 Jan, 21:31
Andrew Schwartzmeyer   Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`. Mon, 29 Jan, 21:45
Mesos Reviewbot Windows     Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`. Mon, 29 Jan, 22:18
Andrew Schwartzmeyer     Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`. Wed, 31 Jan, 18:33
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · Next »Thread · Author · Date
Box list
Sep 202127
Aug 202118
Jul 202145
Jun 2021122
May 2021118
Apr 20215
Mar 20214
Feb 20215
Jan 202144
Dec 202017
Nov 202011
Oct 202050
Sep 2020188
Aug 2020388
Jul 2020125
Jun 202033
May 2020154
Apr 2020285
Mar 2020342
Feb 2020191
Jan 2020303
Dec 2019159
Nov 2019239
Oct 2019162
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338