mesos-reviews mailing list archives: January 2018

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · Next »Thread · Author · Date
Gaston Kleiman Review Request 65300: Added master metrics for operation status acknowledgments handling. Tue, 23 Jan, 22:17
Greg Mann   Re: Review Request 65300: Added master metrics for operation status acknowledgments handling. Thu, 25 Jan, 22:20
Gaston Kleiman   Re: Review Request 65300: Added master metrics for operation status acknowledgments handling. Fri, 26 Jan, 21:45
Gaston Kleiman     Re: Review Request 65300: Added master metrics for operation status acknowledgments handling. Fri, 26 Jan, 22:08
Chun-Hung Hsiao Review Request 65301: Fixed resource statistics for Docker containers being destroyed. Tue, 23 Jan, 23:29
Mesos Reviewbot Windows   Re: Review Request 65301: Fixed resource statistics for Docker containers being destroyed. Tue, 23 Jan, 23:57
Jie Yu   Re: Review Request 65301: Fixed resource statistics for Docker containers being destroyed. Wed, 24 Jan, 01:11
Benjamin Mahler Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. Wed, 24 Jan, 00:54
Mesos Reviewbot Windows   Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. Wed, 24 Jan, 01:27
Alexander Rojas   Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. Wed, 24 Jan, 11:07
Alexander Rukletsov   Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. Wed, 24 Jan, 16:34
Alexander Rukletsov   Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. Wed, 24 Jan, 17:18
Benjamin Mahler     Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. Wed, 24 Jan, 20:23
Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`.
Qian Zhang   Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`. Wed, 24 Jan, 01:08
Mesos Reviewbot Windows   Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`. Wed, 24 Jan, 01:57
Jie Yu   Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`. Wed, 24 Jan, 02:11
Qian Zhang     Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`. Thu, 25 Jan, 00:51
Jie Yu   Re: Review Request 65306: Updated the way to output error messages in `NetworkCniIsolatorSetup`. Wed, 24 Jan, 23:20
Re: Review Request 64062: Added 6 nested container tests for `docker/volume` isolator.
Gilbert Song   Re: Review Request 64062: Added 6 nested container tests for `docker/volume` isolator. Wed, 24 Jan, 03:27
Mesos Reviewbot Windows   Re: Review Request 64062: Added 6 nested container tests for `docker/volume` isolator. Wed, 24 Jan, 03:58
Re: Review Request 63365: Re-ordered some configuration options alphabetically.
Benno Evers   Re: Review Request 63365: Re-ordered some configuration options alphabetically. Wed, 24 Jan, 13:58
Benno Evers Review Request 65308: WIP: Fix warnings in tests. Wed, 24 Jan, 14:57
Benno Evers   Re: Review Request 65308: Fix shadowed sign-compare and enum-compare warnings in tests. Wed, 24 Jan, 16:17
Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().
Benno Evers   Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). Wed, 24 Jan, 15:12
Michael Park     Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). Wed, 24 Jan, 17:02
Benno Evers       Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). Thu, 25 Jan, 17:41
Benno Evers Review Request 65289: Reverted usage of the -isystem flag for includes (2/3). Wed, 24 Jan, 16:23
Benno Evers Review Request 65290: Reverted usage of the -isystem flag for includes (3/3). Wed, 24 Jan, 16:23
Mesos Reviewbot Windows   Re: Review Request 65290: Reverted usage of the -isystem flag for includes (3/3). Wed, 24 Jan, 17:17
Re: Review Request 63366: Added jemalloc release tarball and build rules.
Benno Evers   Re: Review Request 63366: Added jemalloc release tarball and build rules. Wed, 24 Jan, 16:37
Benno Evers   Re: Review Request 63366: Added jemalloc release tarball and build rules. Wed, 24 Jan, 16:42
Benno Evers Review Request 65307: Cleaned up interface defintion in duration header. Wed, 24 Jan, 16:38
Alexander Rukletsov   Re: Review Request 65307: Cleaned up interface defintion in duration header. Wed, 24 Jan, 16:42
Re: Review Request 63372: Added documentation for memory profiling.
Benno Evers   Re: Review Request 63372: Added documentation for memory profiling. Wed, 24 Jan, 16:40
Mesos Reviewbot Windows     Re: Review Request 63372: Added documentation for memory profiling. Wed, 24 Jan, 17:18
Alexander Rojas Review Request 65310: Added lambda::zip. Wed, 24 Jan, 17:26
Mesos Reviewbot Windows   Re: Review Request 65310: Added lambda::zip. Wed, 24 Jan, 17:51
Alexander Rojas   Re: Review Request 65310: Added lambda::zip. Thu, 25 Jan, 15:34
Alexander Rojas Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. Wed, 24 Jan, 17:30
Greg Mann   Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. Fri, 26 Jan, 04:01
Alexander Rojas Review Request 65312: Refactored authorization logic in the master. Wed, 24 Jan, 17:30
Alexander Rojas Review Request 65313: Refactored authorization logic in the agent. Wed, 24 Jan, 17:30
Alexander Rojas Review Request 65314: Removed code which is not used. Wed, 24 Jan, 17:30
Mesos Reviewbot Windows   Re: Review Request 65314: Removed code which is not used. Wed, 24 Jan, 18:21
Mesos Reviewbot Windows   Re: Review Request 65314: Removed code which is not used. Thu, 25 Jan, 16:54
Mesos Reviewbot Windows   Re: Review Request 65314: Removed code which is not used. Thu, 25 Jan, 17:41
Greg Mann Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests. Wed, 24 Jan, 18:05
Mesos Reviewbot Windows   Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests. Wed, 24 Jan, 18:58
Gaston Kleiman   Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests. Sat, 27 Jan, 01:25
Greg Mann     Re: Review Request 65315: Removed a redundant authorization helper class from the tests. Wed, 31 Jan, 02:52
Greg Mann   Re: Review Request 65315: Removed a redundant authorization helper class from the tests. Wed, 31 Jan, 02:52
Andrei Budnik Review Request 65317: Used a namespace for paths in IOSwitchboard. Wed, 24 Jan, 18:10
Alexander Rukletsov   Re: Review Request 65317: Used a namespace for paths in IOSwitchboard. Wed, 24 Jan, 23:55
James Peach Review Request 65319: Implement os::eraseenv on Windows. Wed, 24 Jan, 19:06
Andrew Schwartzmeyer   Re: Review Request 65319: Implement os::eraseenv on Windows. Wed, 24 Jan, 19:09
Akash Gupta   Re: Review Request 65319: Implement os::eraseenv on Windows. Wed, 24 Jan, 19:10
Mesos Reviewbot Windows   Re: Review Request 65319: Implement os::eraseenv on Windows. Wed, 24 Jan, 20:17
Greg Mann Review Request 65316: Added test for delayed authorization during operator events. Wed, 24 Jan, 19:34
Greg Mann   Re: Review Request 65316: Added test for delayed authorization during operator events. Wed, 24 Jan, 19:38
Gaston Kleiman     Re: Review Request 65316: Added test for delayed authorization during operator events. Wed, 24 Jan, 19:49
Greg Mann     Re: Review Request 65316: Added test for delayed authorization during operator events. Wed, 24 Jan, 19:50
Greg Mann       Re: Review Request 65316: Added test for delayed authorization during operator events. Wed, 24 Jan, 20:04
Mesos Reviewbot Windows         Re: Review Request 65316: Added test for delayed authorization during operator events. Wed, 24 Jan, 20:47
Gaston Kleiman         Re: Review Request 65316: Added test for delayed authorization during operator events. Sat, 27 Jan, 01:21
Greg Mann         Re: Review Request 65316: Added test for delayed authorization during operator events. Wed, 31 Jan, 02:53
Mesos Reviewbot Windows           Re: Review Request 65316: Added test for delayed authorization during operator events. Wed, 31 Jan, 03:48
Till Toenshoff Review Request 65320: WIP: Conditionally set LIBPROCESS_IP into docker container. Wed, 24 Jan, 21:38
Till Toenshoff Review Request 65323: WIP: Updated mesos containerizer to conditionally to ignore GPU isolator creation failure. Wed, 24 Jan, 21:38
Mesos Reviewbot Windows   Re: Review Request 65323: WIP: Updated mesos containerizer to conditionally to ignore GPU isolator creation failure. Wed, 24 Jan, 22:09
Till Toenshoff Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter. Wed, 24 Jan, 21:40
Gaston Kleiman   Re: Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter. Wed, 24 Jan, 22:23
Mesos Reviewbot Windows   Re: Review Request 65324: WIP: Updated web UI URL generation to conditionally make it work with adminrouter. Wed, 24 Jan, 22:38
Andrew Schwartzmeyer Review Request 65326: Fixed conversion warning. Wed, 24 Jan, 21:48
Benjamin Bannier   Re: Review Request 65326: Fixed conversion warning. Wed, 24 Jan, 21:56
Andrew Schwartzmeyer     Re: Review Request 65326: Fixed conversion warning. Wed, 24 Jan, 22:14
Andrew Schwartzmeyer   Re: Review Request 65326: Fixed conversion warning. Wed, 24 Jan, 22:16
Mesos Reviewbot Windows     Re: Review Request 65326: Fixed conversion warning. Wed, 24 Jan, 23:08
Benjamin Bannier     Re: Review Request 65326: Fixed conversion warning. Wed, 24 Jan, 23:15
Chun-Hung Hsiao Review Request 65332: Tested that a CSI persistent volume can be used after recovery. Thu, 25 Jan, 01:56
Greg Mann   Re: Review Request 65332: Tested that a CSI persistent volume can be used after recovery. Thu, 25 Jan, 19:27
Chun-Hung Hsiao   Re: Review Request 65332: Tested that a CSI persistent volume can be used after recovery. Wed, 31 Jan, 01:02
Chun-Hung Hsiao Review Request 65333: Fixed errors in comments. Thu, 25 Jan, 01:56
Greg Mann   Re: Review Request 65333: Fixed errors in comments. Thu, 25 Jan, 19:29
Chun-Hung Hsiao   Re: Review Request 65333: Fixed errors in comments. Wed, 31 Jan, 01:03
Benjamin Mahler Review Request 65334: Added quota limit to the master API protos. Thu, 25 Jan, 02:45
Mesos Reviewbot Windows   Re: Review Request 65334: Added quota limit to the master API protos. Thu, 25 Jan, 03:48
Qian Zhang   Re: Review Request 65334: Added quota limit to the master API protos. Thu, 25 Jan, 13:40
Benjamin Mahler   Re: Review Request 65334: Added quota limit to the master API protos. Wed, 31 Jan, 00:21
Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.
Benjamin Bannier   Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 06:32
Mesos Reviewbot Windows     Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 07:37
Benno Evers     Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 13:18
Benjamin Bannier       Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 14:32
Benjamin Bannier     Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 14:32
Mesos Reviewbot Windows       Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 15:24
Till Toenshoff       Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 16:02
Mesos Reviewbot Windows       Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 16:08
Benjamin Bannier       Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 16:17
Re: Review Request 63368: Added MemoryProfiler class to Libprocess.
Benno Evers   Re: Review Request 63368: Added MemoryProfiler class to Libprocess. Thu, 25 Jan, 14:24
Benno Evers   Re: Review Request 63368: Added MemoryProfiler class to Libprocess. Thu, 25 Jan, 14:49
Alexander Rukletsov   Re: Review Request 63368: Added MemoryProfiler class to Libprocess. Fri, 26 Jan, 17:31
Benno Evers     Re: Review Request 63368: Added MemoryProfiler class to Libprocess. Mon, 29 Jan, 10:54
James Peach Review Request 65343: Adopted `DEFAULT_TEST_TIMEOUT` in libprocess tests. Thu, 25 Jan, 19:15
Re: Review Request 65294: Add revocable resources support to mesos-execute.
Anish Gupta   Re: Review Request 65294: Add revocable resources support to mesos-execute. Thu, 25 Jan, 21:10
Zhitao Li     Re: Review Request 65294: Add revocable resources support to mesos-execute. Fri, 26 Jan, 17:19
James Peach     Re: Review Request 65294: Add revocable resources support to mesos-execute. Fri, 26 Jan, 21:27
Zhitao Li   Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`. Tue, 30 Jan, 00:03
Mesos Reviewbot Windows     Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`. Tue, 30 Jan, 00:58
Anish Gupta     Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`. Wed, 31 Jan, 00:29
Jason Lai     Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`. Wed, 31 Jan, 04:05
James Peach     Re: Review Request 65294: Support `revocable_resources` capability in `mesos-execute`. Wed, 31 Jan, 05:52
Greg Mann Review Request 65344: Updated the docs for agent ping timeout flags. Thu, 25 Jan, 21:18
Mesos Reviewbot Windows   Re: Review Request 65344: Updated the docs for agent ping timeout flags. Thu, 25 Jan, 22:05
Mesos Reviewbot Windows   Re: Review Request 65344: Updated the docs for agent ping timeout flags. Thu, 25 Jan, 22:48
Mesos Reviewbot Windows   Re: Review Request 65344: Updated the docs for agent ping timeout flags. Fri, 26 Jan, 10:31
Vinod Kone   Re: Review Request 65344: Updated the docs for agent ping timeout flags. Tue, 30 Jan, 21:50
Re: Review Request 64297: Updated modules documentation with some more details.
Till Toenshoff   Re: Review Request 64297: Updated modules documentation with some more details. Thu, 25 Jan, 21:58
Kapil Arya     Re: Review Request 64297: Updated modules documentation with some more details. Thu, 25 Jan, 22:08
Till Toenshoff     Re: Review Request 64297: Updated modules documentation with some more details. Thu, 25 Jan, 22:16
Kapil Arya       Re: Review Request 64297: Updated modules documentation with some more details. Thu, 25 Jan, 22:16
Mesos Reviewbot Windows       Re: Review Request 64297: Updated modules documentation with some more details. Thu, 25 Jan, 22:51
Benno Evers Review Request 65347: Added missing protobuf include. Fri, 26 Jan, 11:41
Mesos Reviewbot Windows   Re: Review Request 65347: Added missing protobuf include. Fri, 26 Jan, 12:33
Mesos Reviewbot Windows   Re: Review Request 65347: Added missing protobuf include. Fri, 26 Jan, 13:19
Joseph Wu   Re: Review Request 65347: Added missing protobuf include. Fri, 26 Jan, 20:10
Till Toenshoff   Re: Review Request 65347: Added missing protobuf include. Wed, 31 Jan, 00:05
Review Request 65346: Updated Web UI to show quota guarantee and limit for roles.
Armand Grillet   Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. Fri, 26 Jan, 11:58
Mesos Reviewbot Windows     Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. Fri, 26 Jan, 13:18
Benjamin Mahler   Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. Sat, 27 Jan, 02:33
Armand Grillet     Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. Mon, 29 Jan, 09:47
Jan Schlicht Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers. Fri, 26 Jan, 12:55
Alexander Rukletsov   ***UNCHECKED*** Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers. Fri, 26 Jan, 13:23
Jan Schlicht   Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers. Fri, 26 Jan, 13:31
Mesos Reviewbot Windows     Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers. Fri, 26 Jan, 14:04
Mesos Reviewbot Windows     Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers. Fri, 26 Jan, 14:48
Andrei Budnik Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once. Fri, 26 Jan, 14:17
Mesos Reviewbot Windows   Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once. Fri, 26 Jan, 14:58
Mesos Reviewbot Windows   Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once. Fri, 26 Jan, 15:57
Re: Review Request 63369: Added new '/state' and '/statistics' endpoints to the MemoryProfiler.
Benno Evers   Re: Review Request 63369: Added new '/state' and '/statistics' endpoints to the MemoryProfiler. Fri, 26 Jan, 14:18
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · Next »Thread · Author · Date
Box list
Sep 202128
Aug 202118
Jul 202145
Jun 2021122
May 2021118
Apr 20215
Mar 20214
Feb 20215
Jan 202144
Dec 202017
Nov 202011
Oct 202050
Sep 2020188
Aug 2020388
Jul 2020125
Jun 202033
May 2020154
Apr 2020285
Mar 2020342
Feb 2020191
Jan 2020303
Dec 2019159
Nov 2019239
Oct 2019162
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338