mesos-reviews mailing list archives: January 2018

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · Next »Thread · Author · Date
Gilbert Song Review Request 65139: Reverted "Fixed `wait()` and `destroy()` in composing containerizer.". Sat, 13 Jan, 00:15
Vinod Kone   Re: Review Request 65139: Reverted "Fixed `wait()` and `destroy()` in composing containerizer.". Sat, 13 Jan, 00:36
Gilbert Song Review Request 65140: Reverted "Updated composing containerizer tests.". Sat, 13 Jan, 00:15
Vinod Kone   Re: Review Request 65140: Reverted "Updated composing containerizer tests.". Sat, 13 Jan, 00:37
Gilbert Song Review Request 65141: Fixed the default executor flaky testes in tests/cluster.cpp. Sat, 13 Jan, 00:15
Vinod Kone   Re: Review Request 65141: Fixed the default executor flaky testes in tests/cluster.cpp. Sat, 13 Jan, 00:37
James Peach Review Request 65143: Logged some additional information on a master CHECK. Sat, 13 Jan, 00:44
Gilbert Song   Re: Review Request 65143: Logged some additional information on a master CHECK. Sat, 13 Jan, 00:56
Review Request 65144: Ported `os::which` to Windows.
Andrew Schwartzmeyer   Review Request 65144: Ported `os::which` to Windows. Sat, 13 Jan, 01:33
Jie Yu   Re: Review Request 65144: Ported `os::which` to Windows. Tue, 16 Jan, 18:35
Joseph Wu   Re: Review Request 65144: Ported `os::which` to Windows. Tue, 16 Jan, 18:58
Andrew Schwartzmeyer     Re: Review Request 65144: Ported `os::which` to Windows. Tue, 16 Jan, 19:24
Andrew Schwartzmeyer     Re: Review Request 65144: Ported `os::which` to Windows. Tue, 16 Jan, 19:25
Andrew Schwartzmeyer   Re: Review Request 65144: Ported `os::which` to Windows. Tue, 16 Jan, 20:05
Joseph Wu     Re: Review Request 65144: Ported `os::which` to Windows. Tue, 16 Jan, 20:06
Review Request 65145: Fixed use of `os::which`.
Andrew Schwartzmeyer   Review Request 65145: Fixed use of `os::which`. Sat, 13 Jan, 01:33
Jie Yu   Re: Review Request 65145: Fixed use of `os::which`. Tue, 16 Jan, 18:36
Joseph Wu   Re: Review Request 65145: Fixed use of `os::which`. Tue, 16 Jan, 19:37
Andrew Schwartzmeyer Review Request 65146: Windows: Enabled internet tests. Sat, 13 Jan, 01:33
Mesos Reviewbot Windows   Re: Review Request 65146: Windows: Enabled internet tests. Sat, 13 Jan, 07:31
Review Request 65147: Windows: Fixed docker executor `PATH` variable.
Andrew Schwartzmeyer   Review Request 65147: Windows: Fixed docker executor `PATH` variable. Sat, 13 Jan, 01:35
Mesos Reviewbot Windows     Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable. Sat, 13 Jan, 02:51
Andrew Schwartzmeyer       Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable. Sat, 13 Jan, 06:30
Andrew Schwartzmeyer     Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable. Sat, 13 Jan, 06:31
Mesos Reviewbot Windows       Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable. Sat, 13 Jan, 07:30
Joseph Wu   Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable. Tue, 16 Jan, 19:45
Andrew Schwartzmeyer   Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable. Tue, 16 Jan, 20:05
Mesos Reviewbot Windows     Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable. Tue, 16 Jan, 21:01
Andrew Schwartzmeyer     Re: Review Request 65147: Windows: Fixed docker executor `PATH` variable. Tue, 16 Jan, 21:26
Re: Review Request 61158: Introduced http::Server in process.cpp.
Benjamin Mahler   Re: Review Request 61158: Introduced http::Server in process.cpp. Sat, 13 Jan, 02:21
Michael Park Review Request 65149: MesosTidy: Enabled `mesos-this-capture`. Sat, 13 Jan, 05:32
Mesos Reviewbot Windows   Re: Review Request 65149: MesosTidy: Enabled `mesos-this-capture`. Sat, 13 Jan, 06:33
Benjamin Bannier   Re: Review Request 65149: MesosTidy: Enabled `mesos-this-capture`. Sat, 13 Jan, 07:27
Benjamin Mahler Review Request 65150: Added support for discarding a Future from Queue::get. Sat, 13 Jan, 21:35
Benjamin Hindman   Re: Review Request 65150: Added support for discarding a Future from Queue::get. Mon, 15 Jan, 20:52
Benjamin Mahler   Re: Review Request 65150: Added support for discarding a Future from Queue::get. Tue, 16 Jan, 21:40
Benjamin Mahler Review Request 65151: Added a test for discarding a future from Queue::get. Sat, 13 Jan, 21:35
Mesos Reviewbot Windows   Re: Review Request 65151: Added a test for discarding a future from Queue::get. Sat, 13 Jan, 22:02
Benjamin Hindman   Re: Review Request 65151: Added a test for discarding a future from Queue::get. Mon, 15 Jan, 21:03
Re: Review Request 64073: Fixed ignored Socket::accept discard when using LibeventSSLSocketImpl.
Benjamin Mahler   Re: Review Request 64073: Fixed ignored Socket::accept discard when using LibeventSSLSocketImpl. Sat, 13 Jan, 21:36
Re: Review Request 64910: Used `loop`() for `SocketManager` socket sending.
Benjamin Mahler   Re: Review Request 64910: Used `loop`() for `SocketManager` socket sending. Sat, 13 Jan, 22:01
James Peach Review Request 65153: Stopped applying empty executor resources in `network/ports` recovery. Sun, 14 Jan, 05:05
Mesos Reviewbot Windows   Re: Review Request 65153: Stopped applying empty executor resources in `network/ports` recovery. Sun, 14 Jan, 06:03
Qian Zhang   Re: Review Request 65153: Stopped applying empty executor resources in `network/ports` recovery. Tue, 16 Jan, 02:18
Qian Zhang Review Request 65156: Detached the virtual paths regardless of the result of gc. Sun, 14 Jan, 14:17
Mesos Reviewbot Windows   Re: Review Request 65156: Detached the virtual paths regardless of the result of gc. Sun, 14 Jan, 15:13
Vinod Kone   Re: Review Request 65156: Detached the virtual paths regardless of the result of gc. Sun, 14 Jan, 19:01
Qian Zhang     Re: Review Request 65156: Detached the virtual paths regardless of the result of gc. Mon, 15 Jan, 01:16
Qian Zhang   Re: Review Request 65156: Detached the virtual paths regardless of the result of gc. Mon, 15 Jan, 01:16
Qian Zhang     Re: Review Request 65156: Detached the virtual paths regardless of the result of gc. Wed, 17 Jan, 01:37
Re: Review Request 64911: Refactored connection logic in libprocess.
Benjamin Mahler   Re: Review Request 64911: Refactored connection logic in libprocess. Sun, 14 Jan, 21:42
Mesos Reviewbot Windows   Re: Review Request 64911: Refactored connection logic in libprocess. Sun, 14 Jan, 21:50
Benjamin Bannier Review Request 65160: Removed some redundant `get` calls in stout. Mon, 15 Jan, 09:09
Benjamin Bannier Review Request 65161: Removed some redundant `get` calls in libprocess. Mon, 15 Jan, 09:09
Benjamin Bannier Review Request 65162: Removed some redundant `get` calls. Mon, 15 Jan, 09:09
Mesos Reviewbot Windows   Re: Review Request 65162: Removed some redundant `get` calls. Mon, 15 Jan, 10:03
Mesos Reviewbot Windows   Re: Review Request 65162: Removed some redundant `get` calls. Wed, 17 Jan, 12:22
Benjamin Bannier Review Request 65166: Added libprocess benchmarks to cmake build setup. Mon, 15 Jan, 11:48
Mesos Reviewbot Windows   Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Mon, 15 Jan, 12:44
Joseph Wu   Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 18:58
Benjamin Bannier     Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 20:42
Benjamin Bannier   Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 20:42
Andrew Schwartzmeyer     Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 22:12
Andrew Schwartzmeyer       Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 22:13
Mesos Reviewbot Windows     Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 22:13
Andrew Schwartzmeyer     Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 22:13
Benjamin Bannier     Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Thu, 18 Jan, 10:36
Qian Zhang Review Request 65167: Detached `virtualLatestPath` when recovering the executor. Mon, 15 Jan, 13:49
Mesos Reviewbot Windows   Re: Review Request 65167: Detached `virtualLatestPath` when recovering the executor. Mon, 15 Jan, 14:44
Vinod Kone   Re: Review Request 65167: Detached `virtualLatestPath` when recovering the executor. Tue, 16 Jan, 17:29
Zhitao Li   Re: Review Request 65167: Detached `virtualLatestPath` when recovering the executor. Tue, 16 Jan, 17:36
Andrei Budnik Review Request 65168: This patch is needed to trigger ASF CI build. Mon, 15 Jan, 14:10
Mesos Reviewbot Windows   Re: Review Request 65168: This patch is needed to trigger ASF CI build. Mon, 15 Jan, 15:44
Benjamin Hindman Review Request 65171: Reduced copying of Response by adding extra override Headers. Mon, 15 Jan, 20:46
Mesos Reviewbot Windows   Re: Review Request 65171: Reduced copying of Response by adding extra override Headers. Mon, 15 Jan, 20:50
Mesos Reviewbot Windows   Re: Review Request 65171: Reduced copying of Response by adding extra override Headers. Mon, 15 Jan, 21:00
Benjamin Mahler   Re: Review Request 65171: Reduced copying of Response by adding extra override Headers. Mon, 15 Jan, 21:06
Mesos Reviewbot Windows   Re: Review Request 65171: Reduced copying of Response by adding extra override Headers. Mon, 15 Jan, 22:10
Mesos Reviewbot Windows   Re: Review Request 65171: Reduced copying of Response by adding extra override Headers. Mon, 15 Jan, 23:04
Re: Review Request 61157: Refactored ProcessManager::handle for future use with http::Server.
Benjamin Mahler   Re: Review Request 61157: Refactored ProcessManager::handle for future use with http::Server. Mon, 15 Jan, 20:58
Andrei Budnik Review Request 65179: Fixed flaky EOFBeforeRecv test. Tue, 16 Jan, 18:10
Mesos Reviewbot Windows   Re: Review Request 65179: Fixed flaky EOFBeforeRecv test. Tue, 16 Jan, 19:04
Greg Mann   Re: Review Request 65179: Fixed flaky EOFBeforeRecv test. Wed, 17 Jan, 16:41
Alexander Rukletsov   Re: Review Request 65179: Fixed flaky EOFBeforeRecv test. Wed, 17 Jan, 16:51
Andrei Budnik Review Request 65180: Removed a comment in io switchboard. Tue, 16 Jan, 19:05
Kevin Klues   Re: Review Request 65180: Removed a comment in io switchboard. Tue, 16 Jan, 19:24
Andrei Budnik     Re: Review Request 65180: Removed a comment in io switchboard. Tue, 16 Jan, 19:39
Andrei Budnik     Re: Review Request 65180: Removed a comment in io switchboard. Wed, 17 Jan, 11:37
Mesos Reviewbot Windows   Re: Review Request 65180: Removed a comment in io switchboard. Tue, 16 Jan, 20:03
Andrei Budnik   Re: Review Request 65180: Removed a comment in io switchboard. Wed, 17 Jan, 11:36
Mesos Reviewbot Windows     Re: Review Request 65180: Removed a comment in io switchboard. Wed, 17 Jan, 13:20
Alexander Rukletsov     Re: Review Request 65180: Removed a comment in io switchboard. Wed, 24 Jan, 23:56
Gaston Kleiman Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. Tue, 16 Jan, 21:00
Mesos Reviewbot Windows   Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. Tue, 16 Jan, 21:10
Mesos Reviewbot Windows   Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. Wed, 17 Jan, 00:13
Mesos Reviewbot Windows   Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. Thu, 18 Jan, 00:13
Mesos Reviewbot Windows   Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. Fri, 19 Jan, 04:13
Greg Mann   Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. Fri, 19 Jan, 22:38
Gaston Kleiman   Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. Fri, 19 Jan, 23:07
Mesos Reviewbot Windows     Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery. Sat, 20 Jan, 00:05
Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support.
Benjamin Mahler   Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support. Tue, 16 Jan, 21:41
Mesos Reviewbot Windows     Re: Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support. Tue, 16 Jan, 22:31
Joseph Wu   Re: Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support. Wed, 24 Jan, 23:10
Benjamin Mahler     Re: Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support. Wed, 24 Jan, 23:21
Greg Mann Review Request 65184: Added missing registry-related flags to the master config docs. Tue, 16 Jan, 23:16
Vinod Kone   Re: Review Request 65184: Added missing registry-related flags to the master config docs. Tue, 16 Jan, 23:20
Mesos Reviewbot Windows   Re: Review Request 65184: Added missing registry-related flags to the master config docs. Wed, 17 Jan, 00:10
Re: Review Request 64823: Documented the change in the Protobuf requirement.
Benjamin Bannier   Re: Review Request 64823: Documented the change in the Protobuf requirement. Wed, 17 Jan, 11:31
Mesos Reviewbot Windows   Re: Review Request 64823: Documented the change in the Protobuf requirement. Wed, 17 Jan, 12:30
Benjamin Bannier Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Wed, 17 Jan, 12:22
Mesos Reviewbot Windows   Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Wed, 17 Jan, 14:10
Armand Grillet   Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Mon, 22 Jan, 09:22
Benjamin Bannier   Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Mon, 22 Jan, 13:58
Mesos Reviewbot Windows     Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Mon, 22 Jan, 15:03
Armand Grillet     Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Mon, 22 Jan, 15:24
Benjamin Bannier     Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Thu, 25 Jan, 08:28
Benjamin Bannier     Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Thu, 25 Jan, 08:40
Mesos Reviewbot Windows       Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Thu, 25 Jan, 09:47
Armand Grillet       Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Thu, 25 Jan, 09:59
Till Toenshoff       Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Thu, 25 Jan, 15:03
Andrei Budnik Review Request 65190: Updated comments in io switchboard. Wed, 17 Jan, 15:15
Andrei Budnik   Re: Review Request 65190: Updated comments in io switchboard. Wed, 17 Jan, 16:11
Mesos Reviewbot Windows     Re: Review Request 65190: Updated comments in io switchboard. Wed, 17 Jan, 16:13
Alexander Rukletsov     Re: Review Request 65190: Updated comments in io switchboard. Wed, 17 Jan, 16:14
Alexander Rukletsov     Re: Review Request 65190: Updated comments in io switchboard. Wed, 17 Jan, 16:15
Re: Review Request 62160: Fixed stout build with newer boost versions.
Benno Evers   Re: Review Request 62160: Fixed stout build with newer boost versions. Wed, 17 Jan, 16:06
Re: Review Request 62444: Added UNREACHABLE() macro to __cxa_pure_virtual.
Benno Evers   Re: Review Request 62444: Added UNREACHABLE() macro to __cxa_pure_virtual. Wed, 17 Jan, 16:07
Re: Review Request 62161: Updated boost version.
Benno Evers   Re: Review Request 62161: Updated boost version. Wed, 17 Jan, 16:09
Re: Review Request 62445: Removed duplicate block in configure.ac.
Benno Evers   Re: Review Request 62445: Removed duplicate block in configure.ac. Wed, 17 Jan, 16:10
Re: Review Request 62447: Reverted usage of `-isystem` flag.
Benno Evers   Re: Review Request 62447: Reverted usage of `-isystem` flag. Wed, 17 Jan, 16:10
Mesos Reviewbot Windows     Re: Review Request 62447: Reverted usage of `-isystem` flag. Wed, 17 Jan, 16:20
Benjamin Bannier     Re: Review Request 62447: Reverted usage of `-isystem` flag. Tue, 23 Jan, 14:18
Benno Evers     Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3). Wed, 24 Jan, 14:57
Mesos Reviewbot Windows       Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3). Wed, 24 Jan, 15:27
Benno Evers       Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3). Wed, 24 Jan, 16:18
Mesos Reviewbot Windows         Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3). Wed, 24 Jan, 16:47
Andrew Schwartzmeyer           Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3). Wed, 24 Jan, 18:54
Re: Review Request 63828: Added authorization tests for standalone container APIs.
Joseph Wu   Re: Review Request 63828: Added authorization tests for standalone container APIs. Wed, 17 Jan, 19:21
Mesos Reviewbot Windows     Re: Review Request 63828: Added authorization tests for standalone container APIs. Wed, 17 Jan, 20:23
Re: Review Request 63848: Added test to check standalone containers in GET_CONTAINERS.
Joseph Wu   Re: Review Request 63848: Added test to check standalone containers in GET_CONTAINERS. Wed, 17 Jan, 19:21
Mesos Reviewbot Windows     Re: Review Request 63848: Added test to check standalone containers in GET_CONTAINERS. Wed, 17 Jan, 20:20
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · Next »Thread · Author · Date
Box list
Sep 202122
Aug 202118
Jul 202145
Jun 2021122
May 2021118
Apr 20215
Mar 20214
Feb 20215
Jan 202144
Dec 202017
Nov 202011
Oct 202050
Sep 2020188
Aug 2020388
Jul 2020125
Jun 202033
May 2020154
Apr 2020285
Mar 2020342
Feb 2020191
Jan 2020303
Dec 2019159
Nov 2019239
Oct 2019162
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338