mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 63422: Added os::eraseenv to clear the old environment value.
Date Tue, 23 Jan 2018 20:48:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63422/#review196070
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Jan. 10, 2018, 10:08 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63422/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 10:08 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8140
>     https://issues.apache.org/jira/browse/MESOS-8140
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On Linux, updating the environment with unsetenv(3) does
> not change the value that other processes can inspect
> (e.g. through `/proc/$pid/environ`). We have to overwrite
> the existing value (if any) prior to calling unsetenv(3)
> if we want to ensure that the value is really gone.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/os.hpp 7427bd792368fbacafb23593dfb9213618fdcddf

>   3rdparty/stout/tests/os/env_tests.cpp 0e94b386569b6265c5027cbda82a24daa4efb90b 
> 
> 
> Diff: https://reviews.apache.org/r/63422/diff/5/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message