mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64932: Added example framework converting disk resources.
Date Fri, 05 Jan 2018 05:06:26 GMT


> On Jan. 4, 2018, 8:49 p.m., Gaston Kleiman wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 149 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line149>
> >
> >     This framework never starts tasks, so should we crash or log something saying
that we don't expect to get task status updates?

+1


> On Jan. 4, 2018, 8:49 p.m., Gaston Kleiman wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 165-184 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line165>
> >
> >     This framework will never launch a task, so this is probably not needed.
> >     
> >     Furthermore it should probably crash if it receivres an executor failure...

FAILURE events can also signal that an agent was removed, so this could happen.


> On Jan. 4, 2018, 8:49 p.m., Gaston Kleiman wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 331-332 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line331>
> >
> >     I'd phrase it:
> >     
> >     If we didn't create an `ACCEPT` operation, create a `DELCINE` operation.

+1


> On Jan. 4, 2018, 8:49 p.m., Gaston Kleiman wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 335 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line335>
> >
> >     Remove this line, the if statement ensures that no accept call was created.

The accept field could be set but contain no operations, so I think this line should stay.


> On Jan. 4, 2018, 8:49 p.m., Gaston Kleiman wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 380-386 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line380>
> >
> >     This method doesn't seem to be used. `int main(...)` should probably call `Flags::setUsageMessage`
instead of this.

Yea weird, we have these in a couple other example frameworks as well. Should probably clean
them up when we have a chance.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64932/#review194780
-----------------------------------------------------------


On Jan. 3, 2018, 10:50 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64932/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2018, 10:50 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces an example HTTP framework which transforms
> 'RAW' disk resources from resource providers into 'MOUNT' volumes and
> subsequently unreserves them.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 30cd4d426e797e4c8ee556d1bc3de99830a5fe41 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_csi_user_framework.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64932/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message