mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Review Request 64754: Made helper functions of `Bytes` return a double value.
Date Wed, 20 Dec 2017 22:14:00 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Vinod Kone.

Repository: mesos


This patch makes `kilobytes()`, `megabytes()`, `gigabytes()` and
`terabytes()` return doubles to keep the precisions.

NOTE: In the Mesos codebase, the returned values of these helper
functions except for the ones in the tests and SLRPs are used in the
following 3 ways:

1. Comparing with some constant value.
2. Stringified as part of a log message.
3. Stringified then onsumed by `Resources::parse()`, which will do fixed
   point normalization.

In all cases, the changes introduced in this patch should make no harm,
but just make the result more accurate.


  3rdparty/stout/include/stout/bytes.hpp cbe953662bb86c2f1eef3453f557ea17c0c6d13e 



See later in chain.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message