mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64069: Ensured command executor always honors shutdown request.
Date Wed, 20 Dec 2017 16:02:22 GMT


> On Dec. 15, 2017, 4:48 p.m., Vinod Kone wrote:
> > src/launcher/executor.cpp
> > Lines 768 (patched)
> > <https://reviews.apache.org/r/64069/diff/1/?file=1901225#file1901225line768>
> >
> >     Can you add a test for this?

Writing test is tricky: our test harness does not allow to drop outgoing messages and hence
`RunTaskMessage` from the agent to executor can't be dropped (since executor is running in
a separate process it can't be dropped there as incoming message either). We should consider
either improving our harness or providing an ability to create executors in test processes.
For now, I've done manual testing by dropping the message in exec.cpp.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64069/#review193931
-----------------------------------------------------------


On Dec. 15, 2017, 10:43 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64069/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 
> 
> 
> Diff: https://reviews.apache.org/r/64069/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/64033/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message