mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 64713: Fixed a crash when resubscribing resource providers.
Date Wed, 20 Dec 2017 13:24:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64713/
-----------------------------------------------------------

(Updated Dec. 20, 2017, 2:24 p.m.)


Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.


Changes
-------

Addressed issues and removed test case (because it has some issues that need further investigation).


Bugs: MESOS-8346
    https://issues.apache.org/jira/browse/MESOS-8346


Repository: mesos


Description
-------

If a resource provider resubscribed while its old HTTP connection was
still open, the agent would crash, as a continuation would be called
erroneously. This continuation is now only called when a HTTP connection
is closed by a remote side (i.e. the resource provider) and not when
the resource provider manager closes the connection.


Diffs (updated)
-----

  src/resource_provider/manager.cpp e3fcb64b630924e1bb497625708cad3f0fdc064a 


Diff: https://reviews.apache.org/r/64713/diff/2/

Changes: https://reviews.apache.org/r/64713/diff/1-2/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message