mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64726: Renamed operation protos for consistency.
Date Wed, 20 Dec 2017 02:52:55 GMT


> On Dec. 19, 2017, 5:38 p.m., Greg Mann wrote:
> > include/mesos/v1/scheduler/scheduler.proto
> > Line 250 (original), 250 (patched)
> > <https://reviews.apache.org/r/64726/diff/1/?file=1924093#file1924093line250>
> >
> >     Can probably elaborate the comment here now that the name is shortened.

It still doesn't fit, by just one char =/.


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64726/#review194196
-----------------------------------------------------------


On Dec. 19, 2017, 4:57 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64726/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2017, 4:57 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed operation protos for consistency.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 
>   include/mesos/resource_provider/resource_provider.proto 4534049bce3948f20a00cd704f09173077c8cdf8

>   include/mesos/scheduler/scheduler.proto a7907e2c0a8e0f23690179b9e334377c4acc9068 
>   include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a 
>   include/mesos/v1/resource_provider/resource_provider.proto beb9f1734b8d916150ecc6ed1c5b86f0672cd941

>   include/mesos/v1/scheduler/scheduler.proto e115bca04646133cfa3bbd6e7ba190b69f807f2b

>   src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 
>   src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 
> 
> 
> Diff: https://reviews.apache.org/r/64726/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message