mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64659: Fixed unit tests for volume profile module integration.
Date Tue, 19 Dec 2017 14:32:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64659/
-----------------------------------------------------------

(Updated Dec. 19, 2017, 2:32 p.m.)


Review request for mesos, Jie Yu and Joseph Wu.


Repository: mesos


Description (updated)
-------

This patch loads `liburi_volume_profile` dynamically and uses it in the
unit tests of storage local resource providers.

NOTE: `volume_profile_tests.cpp` is removed from compilation to avoid\
loading `uri_volume_profile.proto` twice.


Diffs (updated)
-----

  src/Makefile.am 4623cfcdd0920367043db47f7ab261496996f33a 
  src/tests/agent_resource_provider_config_api_tests.cpp 3c68b732a1d41561f98206a55ac09d91229f330a

  src/tests/storage_local_resource_provider_tests.cpp 1f11825001768864b61fdebdb24168790d7ec4fe



Diff: https://reviews.apache.org/r/64659/diff/3/

Changes: https://reviews.apache.org/r/64659/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message