mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 64698: Made quota headroom calculation on a per-role basis.
Date Tue, 19 Dec 2017 03:01:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64698/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8339
    https://issues.apache.org/jira/browse/MESOS-8339


Repository: mesos


Description
-------

If a role has more reservation than its quota, the
current quota headroom calculation is insufficient
in guaranteeing quota allocation.
See MESOS-8339.

This patch fixes this bug by calculating quota headroom
on a per-role basis (before aggregating) and no longer
counting unallocated reservations (including quota role's
unallocated reservations) towards quota headroom.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp 2cabafeb7ba0cda482ea4464f19730d2ef30cc5e 


Diff: https://reviews.apache.org/r/64698/diff/1/


Testing
-------

make check and a dedicated test #64699


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message