mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler.
Date Mon, 18 Dec 2017 23:24:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/
-----------------------------------------------------------

(Updated Dec. 18, 2017, 3:24 p.m.)


Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.


Changes
-------

Addressed feedback.


Repository: mesos


Description
-------

The `operation_id` and `framework_id` fields are optional, so they
should only be logged if set.


Diffs (updated)
-----

  src/slave/slave.cpp e69d42a2bfae09e2defcd8333c0434a9fd8bac4c 


Diff: https://reviews.apache.org/r/64590/diff/4/

Changes: https://reviews.apache.org/r/64590/diff/3-4/


Testing
-------

`make check` on GNU/Linux


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message